Improve the help message for an invalid calling convention#100488
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 23, 2022
Merged
Improve the help message for an invalid calling convention#100488bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93601
I mostly followed the suggestions of @nagisa in that issue,
however, I wasn't sure how to check stability for the suggestion of "Do not suggest CCs that cannot be used due to them being unstable and feature not being enabled", so I did not implement that point.I haven't contributed to rustc much, please feel free to point out suggestions! For example, the
.map(|s| Symbol::intern(s)).collect::<Vec<_>>()seems pretty gross performance-wise, but maybe that's OK in error reporting code.