Skip to content

Fixed two macro expansion FPs and added tests#16780

Open
evolo22 wants to merge 3 commits intorust-lang:masterfrom
evolo22:Fix-FP-drop-non-drop-trailing-empty-array-macro
Open

Fixed two macro expansion FPs and added tests#16780
evolo22 wants to merge 3 commits intorust-lang:masterfrom
evolo22:Fix-FP-drop-non-drop-trailing-empty-array-macro

Conversation

@evolo22
Copy link
Copy Markdown

@evolo22 evolo22 commented Mar 30, 2026

Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only includes internal changes, you can just write
changelog: none. Otherwise, please write a short comment
explaining your change.

It's also helpful for us that the lint name is put within backticks (` `),
and then encapsulated by square brackets ([]), for example:

changelog: [`lint_name`]: your change

If your PR fixes an issue, you can add fixes #issue_number into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

  • Followed lint naming conventions
  • Added passing UI tests (including committed .stderr file)
  • cargo test passes locally
  • Executed cargo dev update_lints
  • Added lint documentation
  • Run cargo dev fmt

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR.


Please write a short comment explaining your change (or "none" for internal only changes)

changelog: [drop_non_drop]: fixed issue #16753; Added code that checks if lint occurs in macro expansion.
changelog: [drop_non_drop]: Added test in drop_non_drop.rs in ui tests.
changelog: [trailing_empty_array]: fixed issue #16754; Added code that checks if lint occurs in macro expansion.
changelog: [trailing_empty_array]: Added test in trailing_empty_array.rs in ui tests.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 30, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 30, 2026

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants