Skip to content

Generalize extend_with_drain to VecDeque and BinaryHeap.#16778

Open
kpreid wants to merge 1 commit intorust-lang:masterfrom
kpreid:deqpend
Open

Generalize extend_with_drain to VecDeque and BinaryHeap.#16778
kpreid wants to merge 1 commit intorust-lang:masterfrom
kpreid:deqpend

Conversation

@kpreid
Copy link
Copy Markdown
Contributor

@kpreid kpreid commented Mar 29, 2026

I also modified the code a little more than necessary, in order to make it clearer and shorter; in particular, src_ty is no longer shadowed and the immutable variable is gone.

changelog: [extend_with_drain]: now applies to uses of VecDeque and BinaryHeap as well as Vec

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 29, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 29, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@github-actions
Copy link
Copy Markdown

Lintcheck changes for 0f3eba5

Lint Added Removed Changed
clippy::extend_with_drain 0 0 5

This comment will be updated if you push new changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants