Skip to content

Fix manual_map and manual_filter FN for complex map body#16775

Open
profetia wants to merge 3 commits intorust-lang:masterfrom
profetia:issue16751-cont
Open

Fix manual_map and manual_filter FN for complex map body#16775
profetia wants to merge 3 commits intorust-lang:masterfrom
profetia:issue16751-cont

Conversation

@profetia
Copy link
Copy Markdown
Member

@profetia profetia commented Mar 28, 2026

Closes #16776

Inspired by the original reproducer in #16751. After this PR the two lints no longer require the map/filter body to be a single expression of map/filter.

changelog: [manual_map] fix FN for complex map body
changelog: [manual_filter] fix FN for complex map body

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 28, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

Lintcheck changes for b5e1670

Lint Added Removed Changed
clippy::manual_map 10 0 1

This comment will be updated if you push new changes

@profetia
Copy link
Copy Markdown
Member Author

Also closes #16776 in this PR

@profetia
Copy link
Copy Markdown
Member Author

profetia commented Mar 28, 2026

I feel that manual_filter.rs, manual_map.rs and manual_utils.rs can be merged into one, since we are implementing filter, map and and_then (i.e. filter map).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manual_filter FN when the filter is further mapped

3 participants