Fix manual_map and manual_filter FN for complex map body#16775
Open
profetia wants to merge 3 commits intorust-lang:masterfrom
Open
Fix manual_map and manual_filter FN for complex map body#16775profetia wants to merge 3 commits intorust-lang:masterfrom
manual_map and manual_filter FN for complex map body#16775profetia wants to merge 3 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for b5e1670
This comment will be updated if you push new changes |
Member
Author
|
Also closes #16776 in this PR |
Member
Author
|
I feel that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16776
Inspired by the original reproducer in #16751. After this PR the two lints no longer require the map/filter body to be a single expression of map/filter.
changelog: [
manual_map] fix FN for complex map bodychangelog: [
manual_filter] fix FN for complex map body