fix: add check for image with embedded link#16773
Open
Francisco-Andre-Martins wants to merge 1 commit intorust-lang:masterfrom
Open
fix: add check for image with embedded link#16773Francisco-Andre-Martins wants to merge 1 commit intorust-lang:masterfrom
Francisco-Andre-Martins wants to merge 1 commit intorust-lang:masterfrom
Conversation
This fix adds an aditional check, by checking if the previous element was an image, and ignoring the lack of punctuation for a subsequent link. An aditional test was added to account for this case. Closes rust-lang#16439
Collaborator
|
Some changes occurred in clippy_lints/src/doc cc @notriddle |
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
|
Lintcheck changes for 71e4ac9
This comment will be updated if you push new changes |
notriddle
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adds an aditional check, by checking if the previous element was an image, and ignoring the lack of punctuation for a subsequent link. An aditional test was added to account for this case.
Closes #16439
changelog: [
doc_paragraphs_missing_punctuation]: fixed false positive on images with embedded link and added a test for such a case