Fix byte_char_slices FN on arrays

[profetia]

Closes #16759

changelog: [byte_char_slices] fix FN on arrays

[rustbot]

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[github-actions]

Lintcheck changes for c2cca1a

Lint	Added	Removed	Changed
clippy::byte_char_slices	4	0	0

This comment will be updated if you push new changes

[samueltardieu]

I wonder whether it would be interesting to see how this array is then used. If all uses are adjusted and auto-dereferenced, then suggesting b"…" (without *) would make sense.

[profetia]

Agree.

[profetia]

Implemented. The lint is now moved to late pass. I also avoid arrays with comments or cfg, looking into the lint check results.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.