Skip to content

Multiple fixes to FNs of question_mark#16769

Open
profetia wants to merge 5 commits intorust-lang:masterfrom
profetia:issue16751
Open

Multiple fixes to FNs of question_mark#16769
profetia wants to merge 5 commits intorust-lang:masterfrom
profetia:issue16751

Conversation

@profetia
Copy link
Copy Markdown
Member

@profetia profetia commented Mar 26, 2026

Closes #16751

changelog: [question_mark] fix FN for manual unwrap with if let or match
changelog: [question_mark] fix FN when the match scrutinee is behind reference
changelog: [question_mark] fix FN when match binding is behind ref or mut

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 26, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 26, 2026

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

question_mark doesn't recognize match with None => None arm

3 participants