Open
Conversation
Collaborator
|
rustbot has assigned @samueltardieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for 612b2b0
This comment will be updated if you push new changes |
samueltardieu
requested changes
Mar 27, 2026
Member
There was a problem hiding this comment.
Lintcheck shows false positives. An empty impl block with comments or #[cfg] should not be linted.
Please write a meaningful PR message, the current one looks like LLM verbose output.
When the .fixed file of an unrelated test still triggers the lint, use #![expect] instead of #![allow].
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added exceptions (mostly
#![allow(clippy::unused_impl)]) to the following lints:clippy::unused_implfromclippy::unused_selffixes #16758
changelog: new lint: [
unused_impl]