fix: correct destruction order comments in Drop TempFile example#2002
Merged
marioidival merged 1 commit intorust-lang:masterfrom Apr 1, 2026
Merged
Conversation
…t-lang#1925) The comments incorrectly stated that File's drop runs before the custom drop implementation. In Rust, the custom drop method runs first, and then fields are dropped afterwards. Updated comments to reflect the actual destruction order.
Collaborator
|
r? @marioidival rustbot has assigned @marioidival. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1925
The comments incorrectly stated
File::dropruns before the custom drop implementation. In Rust, the customdropmethod runs first while fields are still alive, then fields are dropped afterwards. Updated comments to reflect the correct destruction order.