feat: support inherent associated type paths#21758
feat: support inherent associated type paths#21758EienMiku wants to merge 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
EienMiku
force-pushed
the
fix-inherent-associated-type-type-paths
branch
2 times, most recently
from
6b29518 to
0bb621e
Compare
This comment has been minimized.
This comment has been minimized.
Add support for resolving paths for inherent associated types
EienMiku
force-pushed
the
fix-inherent-associated-type-type-paths
branch
from
0bb621e to
88e5890
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Extract the inherent impl type alias lookup into a shared `find_inherent_assoc_type()` helper, wire it into IDE path resolution
EienMiku
force-pushed
the
fix-inherent-associated-type-type-paths
branch
from
88e5890 to
f5214dc
Compare
|
To be honest, I'm not keen of that. @rust-lang/rust-analyzer thoughts? |
|
It's on a t-types project goal draft and I guess most of the implementation has been done except trait object things(I'm poking into it but it has some irritating normalization issue), so I guess it worths implementing unless too complex, and this PR seems relatively simple. But perhaps we should wait till much progress has been done on rustc? |
|
☔ The latest upstream changes (possibly #19956) made this pull request unmergeable. Please resolve the merge conflicts. |
4 participants
Fixes #16240
Add path lowering support for inherent associated types (e.g.
A::BwhereBis defined in an inherent impl,feature(inherent_associated_types)).Also added a test
inherent_associated_type_pathincrates\hir-ty\src\tests\traits.rs.