make add_missing_impl_members can handle naming conflicts#21118
Open
Natural-selection1 wants to merge 1 commit intorust-lang:masterfrom
Open
make add_missing_impl_members can handle naming conflicts#21118Natural-selection1 wants to merge 1 commit intorust-lang:masterfrom
Natural-selection1 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Natural-selection1
force-pushed
the
name-conflict
branch
3 times, most recently
from
16aff66 to
0613da2
Compare
Natural-selection1
force-pushed
the
name-conflict
branch
from
0613da2 to
b63be3f
Compare
This comment has been minimized.
This comment has been minimized.
Natural-selection1
force-pushed
the
name-conflict
branch
from
b63be3f to
4b2556a
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
☔ The latest upstream changes (possibly #21886) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #6870
The
add_missing_impl_members.rsfile mainly involves code style adjustments and the addition of tests. The main review should focus onutils.rs.