fix glob typo in workspace.package.include setting#1335
Open
decathorpe wants to merge 1 commit intorust-lang:masterfrom
Open
fix glob typo in workspace.package.include setting#1335decathorpe wants to merge 1 commit intorust-lang:masterfrom
decathorpe wants to merge 1 commit intorust-lang:masterfrom
Conversation
The "testdata/**.toml" value is wrong glob syntax and only matches files inside "testdata/", not in subdirectories. Fix syntax and make it match other values, making it match files in subdirectories as well. Fixes rust-lang#1333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "testdata/**.toml" value is wrong glob syntax and only matches files inside "testdata/", not in subdirectories. Fix syntax and make it match other values, making it match files in subdirectories as well.
Fixes #1333
It would be great to get a new release of the
regexcrate with this fix included. The missing test data currently prevents me from updating to regex v1.12.3 in Fedora Linux.