Backport [TailCallElim] Remove the readonly attribute of byval.#150
Conversation
For checking the readonly attribute. Pre-commit test for D156793. Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D156789 (cherry picked from commit b77e556)
When eliminating a tail call, we modify the values of the arguments. Therefore, if the byval parameter has a readonly attribute, we have to remove it. It is safe because, from the perspective of a caller, the byval parameter is always treated as "readonly," even if the readonly attribute is removed. Fixes llvm#64289. Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D156793 (cherry picked from commit c3f227e)
|
We just updated to LLVM 17 in rust-lang/rust#114048, local branch Ideally, we would just pick this up after it's backported to the upstream |
I will backport to |
I nominated the rust issue for T-compiler discussion. |
This reverts commit a7d11c4. We just want to update the beta branch with the necessary fixes. This branch rustc/16.0-2023-06-05 has completed its mission on the master branch. So we can revert this commit for beta updates.
|
Revert "[clang][WebAssembly] Support wasm32-wasi shared libraries" We just want to update the beta branch with the necessary fixes. |
|
Thanks! |
Yk IR serialiser: Simplify the value lowering map.
2 participants
Differential Revision: https://reviews.llvm.org/D156793.
Related issues:
extern "C"causes miscompilation rust#114312