docs: say that long opts with optional arguments require equals not space#118
docs: say that long opts with optional arguments require equals not space#118correabuscar wants to merge 2 commits intorust-lang:masterfrom
Conversation
4b72c76 to
60f3c15
Compare
with tiny examples see comment: rust-lang#104 (comment)
tgross35
left a comment
There was a problem hiding this comment.
This is rather wordy. Could you express it in a smaller paragraph(s) followed by examples instead? That also makes sure it is accurate.
(sorry that this crate hasn't really been maintained in a while)
see comment: rust-lang#104 (comment) reworded, as requested by tgross35 here: rust-lang#118 (review)
see comment: rust-lang#104 (comment) reworded, as requested by tgross35 here: rust-lang#118 (review)
64264ae to
2d66122
Compare
|
This is much cleaner, thanks for that. I meant examples that are doctests so we'll get this verified though - would you be able to add them? |
Oh, sorry, I misunderstood and this makes your last sentence from before (ie. this I just realized that maybe this PR is not necessarily correct, after seeing this: Lines 169 to 180 in 4084692 As I don't really have the time needed to ensure consistency here(ie. much consideration required), I vote we scrap this PR. Also I don't know how to do those doctests, not without spending a bunch of hours first. |
maybe the wording here isn't ideal, but this PR is so that "we"(or you) don't forget to address it. Can always change wording later, before merging.
see comment: #104 (comment)