Add whole_archive option to cc::Build#688
Closed
onalante-msft wants to merge 1 commit intorust-lang:mainfrom
onalante-msft:whole-archive
Closed
Add whole_archive option to cc::Build#688onalante-msft wants to merge 1 commit intorust-lang:mainfrom onalante-msft:whole-archive
whole_archive option to cc::Build#688onalante-msft wants to merge 1 commit intorust-lang:mainfrom
onalante-msft:whole-archive
Conversation
Contributor
|
Previous PR about this - #671. |
Author
|
My apologies, I completely missed that. That PR is definitely the better option. Thank you for the reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.61 no longer links with
whole-archivein some cases, instead linking in this manner only if requested1. This means that the emitted Cargo metadata can sometimes be insufficient to produce usable artifacts fromcc::Buildoutputs2. A workaround is to setcargo_metadatatofalseand print the appropriaterustc-link-{lib,search}arguments, but having this as a built-in option would be helpful since the default linking mode (with respect to the Cargo metadata) is static linking.Footnotes
https://github.com/rust-lang/rust/blob/1.61.0/RELEASES.md#compatibility-notes ↩
Concrete example:
bind_engineandv_checkfrom here are omitted when linking into acdylib: build script. ↩