feat: Stabilize build.warnings
#16796
+29
−84
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,7 +132,6 @@ Each new feature described below should explain how to use it. | |
| * [script](#script) --- Enable support for single-file `.rs` packages. | ||
| * [lockfile-path](#lockfile-path) --- Allows to specify a path to lockfile other than the default path `<workspace_root>/Cargo.lock`. | ||
| * [native-completions](#native-completions) --- Move cargo shell completions to native completions. | ||
| * [Package message format](#package-message-format) --- Message format for `cargo package`. | ||
| * [`fix-edition`](#fix-edition) --- A permanently unstable edition migration helper. | ||
| * [Plumbing subcommands](https://github.com/crate-ci/cargo-plumbing) --- Low, level commands that act as APIs for Cargo, like `cargo metadata` | ||
|
|
@@ -1839,28 +1838,6 @@ When in doubt, you can discuss this in [#14520](https://github.com/rust-lang/car | |
| - powershell: | ||
| Add `CARGO_COMPLETE=powershell cargo +nightly | Invoke-Expression` to `$PROFILE`. | ||
|
|
||
| ## feature unification | ||
|
|
||
| * RFC: [#3692](https://github.com/rust-lang/rfcs/blob/master/text/3692-feature-unification.md) | ||
|
|
@@ -2348,3 +2325,7 @@ See the [`include` config documentation](config.md#include) for more. | |
| ## pubtime | ||
|
|
||
| The `pubtime` index field has been stabilized in Rust 1.94.0. | ||
|
|
||
| ## warnings | ||
|
|
||
| The `build.warnings` config field has been stabilized in Rust 1.96. | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,24 +22,6 @@ fn make_project_with_rustc_warning() -> Project { | |
| .build() | ||
| } | ||
|
|
||
| #[cargo_test] | ||
| fn clippy() { | ||
| let p = project() | ||
|
|
@@ -56,8 +38,6 @@ fn clippy() { | |
| .build(); | ||
|
|
||
| p.cargo("check") | ||
| .arg("--config") | ||
| .arg("build.warnings='deny'") | ||
| .env("RUSTC_WORKSPACE_WRAPPER", tools::wrapped_clippy_driver()) | ||
|
|
@@ -77,8 +57,6 @@ fn clippy() { | |
| fn config() { | ||
| let p = make_project_with_rustc_warning(); | ||
| p.cargo("check") | ||
| .env("CARGO_BUILD_WARNINGS", "deny") | ||
| .with_stderr_data(str![[r#" | ||
| [CHECKING] foo v0.0.1 ([ROOT]/foo) | ||
|
|
@@ -93,8 +71,6 @@ fn config() { | |
|
|
||
| // CLI has precedence over env | ||
| p.cargo("check") | ||
| .arg("--config") | ||
| .arg("build.warnings='warn'") | ||
| .env("CARGO_BUILD_WARNINGS", "deny") | ||
|
|
@@ -112,8 +88,6 @@ fn config() { | |
| fn unknown_value() { | ||
| let p = make_project_with_rustc_warning(); | ||
| p.cargo("check") | ||
| .arg("--config") | ||
| .arg("build.warnings='forbid'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -146,8 +120,6 @@ fn keep_going() { | |
| .build(); | ||
|
|
||
| p.cargo("build") | ||
| .arg("--config") | ||
| .arg("build.warnings='deny'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -164,8 +136,6 @@ fn keep_going() { | |
| assert!(!p.bin("foo").is_file()); | ||
|
|
||
| p.cargo("build --keep-going") | ||
| .arg("--config") | ||
| .arg("build.warnings='deny'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -189,8 +159,6 @@ fn keep_going() { | |
| fn rustc_caching_allow_first() { | ||
| let p = make_project_with_rustc_warning(); | ||
| p.cargo("check") | ||
| .arg("--config") | ||
| .arg("build.warnings='allow'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -201,8 +169,6 @@ fn rustc_caching_allow_first() { | |
| .run(); | ||
|
|
||
| p.cargo("check") | ||
| .arg("--config") | ||
| .arg("build.warnings='deny'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -220,8 +186,6 @@ fn rustc_caching_allow_first() { | |
| fn rustc_caching_deny_first() { | ||
| let p = make_project_with_rustc_warning(); | ||
| p.cargo("check") | ||
| .arg("--config") | ||
| .arg("build.warnings='deny'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -236,8 +200,6 @@ fn rustc_caching_deny_first() { | |
| .run(); | ||
|
|
||
| p.cargo("check") | ||
| .arg("--config") | ||
| .arg("build.warnings='allow'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -300,8 +262,6 @@ fn hard_warning_deny() { | |
|
|
||
| // Behavior under test | ||
| p.cargo("rustc") | ||
| .arg("--config") | ||
| .arg("build.warnings='deny'") | ||
| .arg("--") | ||
|
|
@@ -370,8 +330,6 @@ fn hard_warning_allow() { | |
|
|
||
| // Behavior under test | ||
| p.cargo("rustc") | ||
| .arg("--config") | ||
| .arg("build.warnings='allow'") | ||
| .arg("--") | ||
|
|
@@ -446,8 +404,6 @@ fn cap_lints_deny() { | |
|
|
||
| // Behavior under test | ||
| p.cargo("check -vv") | ||
| .arg("--config") | ||
| .arg("build.warnings='deny'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
@@ -520,8 +476,6 @@ fn cap_lints_allow() { | |
|
|
||
| // Behavior under test | ||
| p.cargo("check -vv") | ||
| .arg("--config") | ||
| .arg("build.warnings='allow'") | ||
| .with_stderr_data(str![[r#" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section seems confusing between the terms lint and warning.
The following sounds like all warnings have a lint level that we're adjusting.
This sounds like all lints can have an adjustable lint level that we're changing here.
This is now emitting errors for warnings not lints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is tricky to talk about this precisely enough while not adding so many qualifiers that it makes it hard to follow. My intent with the last paragraph ("Only warnings") was to clarify this.