Skip to content

Deprecate tuple_combinations#1085

Merged
jswrenn merged 6 commits intorust-itertools:masterfrom
phimuemue:deprecate_tuple_combinations
Mar 31, 2026
Merged

Deprecate tuple_combinations#1085
jswrenn merged 6 commits intorust-itertools:masterfrom
phimuemue:deprecate_tuple_combinations

Conversation

@phimuemue
Copy link
Copy Markdown
Member

As agreed upon in #1084 (comment)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.81%. Comparing base (6814180) to head (95a78e3).
⚠️ Report is 184 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
- Coverage   94.38%   93.81%   -0.58%     
==========================================
  Files          48       51       +3     
  Lines        6665     6468     -197     
==========================================
- Hits         6291     6068     -223     
- Misses        374      400      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

I left the original tests, and added their array_combination counterparts.
I left the original tests, array_combination counterparts already present.
I left the original tests, and added their array_combination counterparts.
Note that they do not panic, and I saw no reason why they should.
@phimuemue phimuemue force-pushed the deprecate_tuple_combinations branch from 4c0a468 to 95a78e3 Compare March 18, 2026 12:47
@phimuemue
Copy link
Copy Markdown
Member Author

@jswrenn gentle nudge.

OT: Should we publish 0.15? We had some bug-fixes and other improvements, plus it would make things easier if CI would not fail on each PR.

Even more OT: Can/should we automate publishing somehow? afaik, I'm not allowed to publish to crates.io, but if I can help, let me know.

@jswrenn jswrenn added this pull request to the merge queue Mar 31, 2026
@jswrenn
Copy link
Copy Markdown
Member

jswrenn commented Mar 31, 2026

Yeah, I absolutely should publish 0.15. Release is already semi-automated, but the big manual lift that slows me down is hand-crafting the changelog. I'll bang out a release this week and also get you publish perms so I'm not the bottleneck. :)

Merged via the queue into rust-itertools:master with commit ecda88e Mar 31, 2026
12 of 14 checks passed
@phimuemue phimuemue mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants