Conversation
burrbull
force-pushed
the
const-default
branch
2 times, most recently
from
96ad0c3 to
f6246e3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
burrbull
force-pushed
the
const-default
branch
from
d462120 to
62bb6a5
Compare
burrbull
force-pushed
the
const-default
branch
from
62bb6a5 to
c6316a3
Compare
burrbull
changed the title
burrbull
force-pushed
the
const-default
branch
5 times, most recently
from
d22e32e to
379a857
Compare
Member
Author
|
/ci diff pr |
burrbull
force-pushed
the
const-default
branch
from
379a857 to
e4fdedb
Compare
Member
Author
|
@Emilgardis @adamgreig what do you think about this change? |
Member
|
Not sure i understand why num-traits is needed for this, could you elaborate? |
Member
Author
We can introduce our own |
Emilgardis
previously approved these changes
Mar 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
burrbull
force-pushed
the
const-default
branch
2 times, most recently
from
2dba2b6 to
806734c
Compare
Member
Author
|
cc @Emilgardis rebased |
Member
Author
|
/ci diff pr |
Member
Author
|
cc @Emilgardis let's merge |
Member
|
/ci diff semver |
Member
|
Semver break should be fine, implementations of RawReg shouldnt be done by other crates. That one() is missing should be fine too |
Emilgardis
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advantages:
constszerois more semantically correct thendefaultDisadvantages:
rustdocstill not good withconst defaults. Printsinstead of
const ZERO_TO_MODIFY_FIELDS_BITMAP: u32 = 0for default value.cc @Emilgardis