Support region padding for MPU programming#146
Open
thejpster wants to merge 3 commits intorust-embedded:mainfrom
Open
Support region padding for MPU programming#146thejpster wants to merge 3 commits intorust-embedded:mainfrom
thejpster wants to merge 3 commits intorust-embedded:mainfrom
Conversation
thejpster
changed the title
thejpster
changed the title
wt
reviewed
Mar 24, 2026
wt
left a comment
wt
left a comment
There was a problem hiding this comment.
Everything I didn't mention looks okay assuming all the magic numbers in the reference files are correct.
wt
suggested changes
Mar 24, 2026
* Add an API to get the various linker output sections (aarch32_rt::region) * Adjust link.x to allow for adjustable alignment of regions * Adjust link.x to allow for adjustable padding between stacks * Add an example that programs the MPU
thejpster
force-pushed
the
support-padding
branch
from
38c3005 to
7b2337d
Compare
wt
suggested changes
Mar 29, 2026
aarch32-rt/src/regions.rs
Outdated
| Region::Rodata => Region::Bss, | ||
| Region::Bss => Region::Data, | ||
| Region::Data => Region::Uninit, | ||
| Region::Uninit => return None, |
There was a problem hiding this comment.
Will Uninit ever be returned? I think when self.current is Uninit on entry to this function, it will return None (never returning old in that case) and skip over returning the Uninit enum.
I think making self.current an Option and then making all the current arms valued with Some(x) (no return statement) and None with returning None will fix that.
FWIW, I also wondering if we should rename self.current to self.next and old to current.
Contributor
Author
There was a problem hiding this comment.
Mmmm, that explains why the build actions hung.
As suggested in code review, now we're less likely to forget to update the Iterator when adding new regions/stacks.
thejpster
force-pushed
the
support-padding
branch
from
7b2337d to
b45b312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easier to set up the MPU
The MPS3-AN536 padding is set at 64K, so that the normal build and the +d32 build end up with the same memory map (otherwise their output for the mpu_region example would be different).