Skip to content

fix: clean stdout for --config-only when appending SSH config#192

Merged
tode-rl merged 2 commits intomainfrom
cursor/devbox-ssh-config-output-df3c
Apr 3, 2026
Merged

fix: clean stdout for --config-only when appending SSH config#192
tode-rl merged 2 commits intomainfrom
cursor/devbox-ssh-config-output-df3c

Conversation

@alb-rl
Copy link
Copy Markdown
Contributor

@alb-rl alb-rl commented Apr 3, 2026

Summary

rli devbox ssh <id> --config-only >> ~/.ssh/config was polluting the config file because:

  1. Readiness messages used stdoutwaitForReady logged via console.log, so lines like Devbox … is ready! were captured by the redirect.
  2. Text output wrapped the blockoutput({ config }, …) rendered as config: … instead of a raw Host stanza.

Changes

  • Route all waitForReady status lines to stderr (console.error).
  • For --config-only with default text output, print the generated SSH config with console.log(config) only (no config: prefix). JSON/YAML (-o json|yaml) still use the structured output() helper.

Testing

  • pnpm run build
  • pnpm test

Slack Thread

Open in Web Open in Cursor 

- Send waitForReady progress messages to stderr so they are not appended
  to ~/.ssh/config when redirecting stdout.
- For --config-only with default text output, print raw SSH config instead
  of key-value text that prefixed lines with 'config:'.
@alb-rl alb-rl marked this pull request as ready for review April 3, 2026 00:02
@alb-rl alb-rl changed the title fix(devbox ssh): clean stdout for --config-only when appending SSH config fix: clean stdout for --config-only when appending SSH config Apr 3, 2026
@alb-rl alb-rl requested review from dines-rl and tode-rl April 3, 2026 00:03
- Add cliStatus() writing to stderr (documented as progress, not errors).
- Drop redundant 'is ready!' line after wait succeeds.
- For --config-only, skip wait banner and poll chatter; still print
  timeout/failure/retry exhaustion on stderr.
@tode-rl tode-rl merged commit 4428295 into main Apr 3, 2026
14 checks passed
@tode-rl tode-rl deleted the cursor/devbox-ssh-config-output-df3c branch April 3, 2026 01:52
tode-rl pushed a commit that referenced this pull request Apr 3, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.15.0](v1.14.0...v1.15.0)
(2026-04-03)


### Features

* axon list with pagination and api-client upgrade
([#184](#184))
([dc9743e](dc9743e))
* **cli:** add some (hidden) agent handling commands
([#187](#187))
([1a92f5f](1a92f5f))


### Bug Fixes

* clean stdout for --config-only when appending SSH config
([#192](#192))
([4428295](4428295))
* **cli:** account for pending scenarios in rli display
([#185](#185))
([c82d528](c82d528))
* widen VERSION column in agent list to prevent truncation
([#190](#190))
([c7eba09](c7eba09))


### Performance Improvements

* fetch total count in the background, not foreground
([#189](#189))
([0903d89](0903d89))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants