perf: fetch total count in the background, not foreground#189
Merged
Conversation
jason-rl
changed the title
jason-rl
force-pushed
the
jason/total_count_background
branch
3 times, most recently
from
9a740ae to
8569309
Compare
dines-rl
reviewed
Apr 2, 2026
dines-rl
approved these changes
Apr 2, 2026
Contributor
dines-rl
left a comment
dines-rl
left a comment
There was a problem hiding this comment.
see comments if I'm wrong you can merge
When there are 0 items (e.g. empty search results or no resources), the stats bar incorrectly showed "Showing 1-0". Now the "Showing" text is hidden entirely when there are no items to display. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jason-rl
force-pushed
the
jason/total_count_background
branch
from
8569309 to
d361751
Compare
tode-rl
pushed a commit
that referenced
this pull request
Apr 3, 2026
🤖 I have created a release *beep* *boop* --- ## [1.15.0](v1.14.0...v1.15.0) (2026-04-03) ### Features * axon list with pagination and api-client upgrade ([#184](#184)) ([dc9743e](dc9743e)) * **cli:** add some (hidden) agent handling commands ([#187](#187)) ([1a92f5f](1a92f5f)) ### Bug Fixes * clean stdout for --config-only when appending SSH config ([#192](#192)) ([4428295](4428295)) * **cli:** account for pending scenarios in rli display ([#185](#185)) ([c82d528](c82d528)) * widen VERSION column in agent list to prevent truncation ([#190](#190)) ([c7eba09](c7eba09)) ### Performance Improvements * fetch total count in the background, not foreground ([#189](#189)) ([0903d89](0903d89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
if total_count isn't known yet
The
of {total_count}is omitted.When fetching current page, if it's still pending, it will show
{beginning number}+since it technically doesn't know the actual ending number since it could be the last page and have less then max #. Once current page is done fetching, it will then show the accurate ending #.if total_count becomes known
We can finally append
of {total_count}Type of Change
Related Issues
Closes #
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes