Skip to content

create_and_await_running() to enable optional input for devbox_create_params.DevboxCreateParams#628

Merged
tode-rl merged 3 commits intomainfrom
tode/fix-default-None-await-helpers
Aug 19, 2025
Merged

create_and_await_running() to enable optional input for devbox_create_params.DevboxCreateParams#628
tode-rl merged 3 commits intomainfrom
tode/fix-default-None-await-helpers

Conversation

@tode-rl
Copy link
Copy Markdown
Contributor

@tode-rl tode-rl commented Aug 19, 2025

No description provided.

@tode-rl tode-rl requested a review from ross-rl August 19, 2025 19:02
@tode-rl tode-rl changed the title create_and_await_running() to enable None as input for devbox_create_params.DevboxCreateParams create_and_await_running() to enable optional input for devbox_create_params.DevboxCreateParams Aug 19, 2025
Copy link
Copy Markdown
Contributor

@ross-rl ross-rl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python default args are kind of scary, you should use the None pattern here. here is a code snippet to demonstrate

def add_item(item, items={}):
    items[item] = True
    return items

# First call
result1 = add_item('apple')
print(result1)  # {'apple': True}

# Second call - the dict persists!
result2 = add_item('banana')
print(result2)  # {'apple': True, 'banana': True}

@tode-rl
Copy link
Copy Markdown
Contributor Author

tode-rl commented Aug 19, 2025

Member

Good catch, reverting and updating as discussed in slack

@tode-rl tode-rl requested a review from ross-rl August 19, 2025 19:55
@tode-rl tode-rl merged commit 55347e2 into main Aug 19, 2025
7 checks passed
@tode-rl tode-rl deleted the tode/fix-default-None-await-helpers branch August 19, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants