feat: make disk sizes configurable on macos#1733
Open
Swapnanil-Gupta wants to merge 5 commits intomainfrom
Open
feat: make disk sizes configurable on macos#1733Swapnanil-Gupta wants to merge 5 commits intomainfrom
Swapnanil-Gupta wants to merge 5 commits intomainfrom
Conversation
Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
Signed-off-by: Swapnanil-Gupta <swpnlg@amazon.com>
Swapnanil-Gupta
force-pushed
the
feat-configurable-disks
branch
from
1e7f403 to
1ad0318
Compare
coderbirju
reviewed
Apr 8, 2026
coderbirju
reviewed
Apr 8, 2026
coderbirju
reviewed
Apr 8, 2026
| settingsVMCommand.Flags().String( | ||
| "datadisk", | ||
| config.DefaultDataDisk, | ||
| "the amount of data disk space (sparse) to give to the virtual machine (restart the vm when applying this change.)", |
Contributor
There was a problem hiding this comment.
Same comment as above, warning that this cannot be lowered in the future
Contributor
Author
There was a problem hiding this comment.
Does not make sense to add a warning here as this command just updates the config and does not perform the resize operation (the resizing happens on next vm start/init).
coderbirju
reviewed
Apr 8, 2026
coderbirju
reviewed
Apr 8, 2026
Contributor
coderbirju
left a comment
coderbirju
left a comment
There was a problem hiding this comment.
Overall LGTM minor nits and questions for my understanding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
datadiskandbootdiskconfig options to finch.yaml to make the size of the data disk (persistent) and boot disk (ephemeral) configurable.Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.