chore(ci): fail on shellcheck warnings#1724
Open
sondavidb wants to merge 2 commits intorunfinch:mainfrom
Open
Conversation
Done with a mix of shellcheck -f diff | git apply and some manual fixes. Signed-off-by: David Son <davbson@amazon.com>
Signed-off-by: David Son <davbson@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Unreverts #684
Description of changes:
Noticed that we are ignoring many shellcheck warnings because we don't fail on them. Fixed all of them the best way I could.
Due to the finnicky nature of shellscripts we should hold off on merging this until after the next Finch release.
Testing done:
Ran
shellcheckon all of the shellscripst locally and ensured nothing above anotelevel linter warning was printedLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.