Open
Conversation
ayush-panta
force-pushed
the
remove-nerdctl-binary-dep
branch
2 times, most recently
from
929f0dd to
814f0fb
Compare
Signed-off-by: ayush-panta <ayushkp@amazon.com>
Signed-off-by: ayush-panta <ayushkp@amazon.com>
Signed-off-by: ayush-panta <ayushkp@amazon.com>
Signed-off-by: ayush-panta <ayushkp@amazon.com>
ayush-panta
force-pushed
the
remove-nerdctl-binary-dep
branch
from
99789b5 to
b8be4df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: finch-daemon currently uses the nerdctl binary for OCI hooks and logging. We can extract relevant logic from nerdctl into a custom binary and use it in place of the original nerdctl binary.
Testing done: Container unit tests work locally, though they are mocks. I also manually tested it by setting the DOCKER_HOST and checking container operations worked as expected. However, I need to use CI to see if the use of the new binary instead of the nerdctl binary maintains functionality of finch-daemon.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.