Allow time inputs to be filled with time strings#306
Allow time inputs to be filled with time strings#306Draiken wants to merge 1 commit intorubycdp:mainfrom
Conversation
|
Just yesterday I moved from selenium to cuprite and I got some failed tests because of this. Had no idea a Time object was needed for the |
|
@albiere after creating the PR and having previously searched for this in the issues, I noticed there are other PRs doing similar changes. All from long ago, with little/no feedback. The GH actions fail with an unrelated issue. I'm afraid this project is not active anymore or maybe the maintainers are on vacation. All this to say that we shouldn't expect this to be merged any time soon. |
|
The reason is - I'm single maintainer not maintainers and I was mostly concentrated on Ferrum rather than Cuprite as Ferrum is core, Cuprite is wrapper. But I'm close to Ferrum 1.0 and now Cuprite/Vessel will get the deserved time. This year we should expect 1.0. I'm closing this PR just because there's older one #245. Sorry that your work is not being merged that's all my bad for not spending enough time on PRs in general. |
Allows us to use time strings like
10:00as values for atimeinput.I've spent a lot of time thinking I had a bug because a simple
fill_in "time_field", with: "10:00"didn't work. It seems to expect a time object only but that's not mentioned anywhere AFAIK.This adds the ability to set times as strings which would work normally in JS
element.value = "10:00"