refactor: make shiny-showcase.ts jQuery-optional with native JS fallbacks#4370
Draft
karangattu wants to merge 2 commits intomainfrom
Draft
refactor: make shiny-showcase.ts jQuery-optional with native JS fallbacks#4370karangattu wants to merge 2 commits intomainfrom
karangattu wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes shiny-showcase.ts work with or without jQuery. When jQuery is present on the page, behavior is identical to today. When it isn't, native browser APIs are used instead. This enables gradual decoupling from jQuery without any breaking changes.
Why
This is a step toward reducing Shiny's dependency on jQuery. By making the showcase JS jQuery-optional rather than removing jQuery outright, existing apps with jQuery continue to work exactly as before, while apps that don't load jQuery also work correctly.