add: verifyInputMessage for mock-session#3791
Open
stefanedwards wants to merge 1 commit intorstudio:mainfrom
Open
add: verifyInputMessage for mock-session#3791stefanedwards wants to merge 1 commit intorstudio:mainfrom
stefanedwards wants to merge 1 commit intorstudio:mainfrom
Conversation
|
|
fed54bb to
9485723
Compare
New manner for testing the contents of `message` when unit testing methods that use `sendInputMessage`. Similar methods should be implemented for session$sendCustomMessage and session$sendBinaryMessage.
9485723 to
c22d0fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Proof of concept"
Added methods to
mock-sessionfor verifying that specific calls tosession$sendInputMessagewere performed. Note: Before merging, these methods should be expanded to includesession$sendCustomMessageandsession$sendBinaryMessage!This suggestion is inspired by how mocked classes in C# with Moq behave; that the mock itself is able to verify whether a given call was performed. By allowing
mock-sessionto verify (upon request, naturally) it makes it easier to write unit tests of Shiny update methods, as the developer doesn't have to write boilerplate code. See e.g. following examples fromtests/testthat/test-update-input.R:Before:
After:
The
verifyInputMessagehas built-in support for thetestthat-package, without depending on it. CallingverifyInputMessageis enough in atest_that:Before:
After (with actual testing):
As noted initially, these methods should be implemented for
sendCustomMessageandsendBinaryMessagebefore including, and I will gladly do this (letting the three methods use the same routine, somehow).