warn when lockfile hash does not match installed package hash#751
Merged
warn when lockfile hash does not match installed package hash#751
Conversation
otherwise it leaks to my test of the hash mismatch warning, causing it to fail when run twice in the same R session
jonkeane
approved these changes
Mar 11, 2026
Comment on lines
+785
to
+787
| "(Package, Version, Depends, Imports, Suggests, LinkingTo, and ", | ||
| "Remote fields such as GithubSHA1, RemoteType, RemoteHost, ", | ||
| "RemoteRepo, RemoteUsername, RemoteRef, RemoteSha, RemoteSubdir) ", |
Contributor
There was a problem hiding this comment.
I'm ok to leave this here since it's simpler, though it's a little fragile cause we'll need to update this if the fields change. But that's a pretty low likelihood event anyway?
Contributor
Author
There was a problem hiding this comment.
yeah I think it's ok and that DRYing it up would just make the logic in hash() more complicated unnecessarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #750