Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

feat: update ResourceConfig to match Rootstock#10

Open
illuque wants to merge 1 commit intorsk/poc-v0from
rsk/iago/resourcemetering
Open

feat: update ResourceConfig to match Rootstock#10
illuque wants to merge 1 commit intorsk/poc-v0from
rsk/iago/resourcemetering

Conversation

@illuque
Copy link
Copy Markdown

@illuque illuque commented Feb 20, 2024

Update ResourceConfig to match Rootstock

Copy link
Copy Markdown

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illuque It's not clear to me how we extracted the new values. Could we please add a clarification on them? Furthermore, I've also noticed that the same parameters are repeated in different parts. Was there any way to define them only once?

Copy link
Copy Markdown
Member

@jurajpiar jurajpiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(I would not bother extracting the values as it would have to be in env vars or some other project-wide config and this is just a POC)

@antomor
Copy link
Copy Markdown

antomor commented Mar 5, 2024

(I would not bother extracting the values as it would have to be in env vars or some other project-wide config and this is just a POC)

It's ok for me for the scope of the PoC not extracting them, but I'd at least document how we got them

@illuque
Copy link
Copy Markdown
Author

illuque commented Mar 5, 2024

@illuque It's not clear to me how we extracted the new values. Could we please add a clarification on them? Furthermore, I've also noticed that the same parameters are repeated in different parts. Was there any way to define them only once?

Values were calculated in a proportional way to our block size compared to theirs as agreed during team discusions. But I will document it, good point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants