Update page on custom interfaces#6312
Open
kacperbojakowski-3di wants to merge 2 commits intoros2:rollingfrom
Open
Update page on custom interfaces#6312kacperbojakowski-3di wants to merge 2 commits intoros2:rollingfrom
kacperbojakowski-3di wants to merge 2 commits intoros2:rollingfrom
Conversation
Updated the article "Implementing custom interfaces - how to" as approved by Geoff and 3di.
Collaborator
|
You have some liner errors to address. |
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
a couple of minor comments. thanks for making contribution.
Comment on lines
+5
to
+6
| Implementing custom interfaces - how-to | ||
| ======================================= |
Collaborator
There was a problem hiding this comment.
this is under how-to section, the title seems redundant for me.
Suggested change
| Implementing custom interfaces - how-to | |
| ======================================= | |
| Implementing custom interfaces | |
| ============================== |
Comment on lines
+12
to
+14
| :: | ||
|
|
||
| Area: ROS-framework | Content-type: how-to | Experience: beginner, intermediate |
Collaborator
There was a problem hiding this comment.
metadata line is placed inside a :: literal block, which means it will render as a code snippet on the page. If this is intended as visible metadata for readers, a literal block feels like an unusual presentation choice?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the article "Implementing custom interfaces - how to" as approved by Geoff and 3di.
Description
Related to: ros2/ros2#1725
Updated the custom interfaces how-to page by replacing the old single-package tutorial with the new revised tutorial, and updated the TOC to add the new page entry and remove/replace the old one (incl. the Beginner-Client-Libraries tutorial list).
Did you use Generative AI?
No.
Additional Information
Documentation updates from 3di Information Solutions, agreed with Geoff and Tully.