Add Specialization Table for Python Container Types#5982
Open
InvincibleRMC wants to merge 4 commits intoros2:rollingfrom
Open
Add Specialization Table for Python Container Types#5982InvincibleRMC wants to merge 4 commits intoros2:rollingfrom
InvincibleRMC wants to merge 4 commits intoros2:rollingfrom
Conversation
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
fujitatomoya
approved these changes
Oct 25, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
The PR title should be "Specialization", not "Specialziation"?
lgtm with green CI.
InvincibleRMC
changed the title
Member
|
It may be because of the jet lag from my trip to Singapore, but I don't really see how this fixes #5820, specifically how this documents the things mentioned in #5820 (comment). Can you explain? |
Contributor
Author
|
Yeah you're right. I'll add comment mentioning about inheriting from Sequence. I think it's probably not worth mentioning set until we discuss it's future. |
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleaned up but, derived from https://design.ros2.org/articles/idl_interface_definition.html.
Fixes #5820
Did you use Generative AI?
Additional Information