Clarify publish behavior for shared_ptr and unique_ptr#5966
Open
Yuchen966 wants to merge 2 commits intoros2:rollingfrom
Open
Clarify publish behavior for shared_ptr and unique_ptr#5966Yuchen966 wants to merge 2 commits intoros2:rollingfrom
Yuchen966 wants to merge 2 commits intoros2:rollingfrom
Conversation
alsora
reviewed
Nov 16, 2025
|
|
||
| **std::unique_ptr messages:** | ||
| - Zero-copy transfer is achieved for the first subscriber | ||
| - Additional subscribers receive copies of the message |
Contributor
There was a problem hiding this comment.
these statements are not really correct.
you can't infer this from publisher alone, but only from the combination of publisher and subscriber.
fujitatomoya
requested changes
Nov 16, 2025
Comment on lines
+167
to
+168
| Understanding publish() behavior with different message types | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
Collaborator
There was a problem hiding this comment.
extra '~'?
Suggested change
| Understanding publish() behavior with different message types | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
| Understanding publish() behavior with different message types | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
Collaborator
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
9938ad9 to
8459420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates some explanation of intra-process communication demo document to reflect the actual current behavior with respect to function
publish():shared_ptrmessages: Cannot be published (removed incorrect zero-copy claims)unique_ptrmessages: Zero-copy transfer achieved for the last subscriberKey changes:
Fixes issue
Did you use Generative AI?
No
Additional Information