Add documentation clarifying FAILURE vs ERROR in CallbackReturn#3087
Open
shlokbandiwar wants to merge 4 commits intoros2:rollingfrom
Open
Add documentation clarifying FAILURE vs ERROR in CallbackReturn#3087shlokbandiwar wants to merge 4 commits intoros2:rollingfrom
shlokbandiwar wants to merge 4 commits intoros2:rollingfrom
Conversation
Signed-off-by: shlokbandiwar <150021561+shlokbandiwar@users.noreply.github.com>
solonovamax
suggested changes
Mar 2, 2026
rclcpp_lifecycle/include/rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp
Outdated
Show resolved
Hide resolved
rclcpp_lifecycle/include/rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp
Outdated
Show resolved
Hide resolved
…embers. Signed-off-by: shlokbandiwar <150021561+shlokbandiwar@users.noreply.github.com>
…e enum members. Signed-off-by: shlokbandiwar <150021561+shlokbandiwar@users.noreply.github.com>
solonovamax
suggested changes
Mar 2, 2026
rclcpp_lifecycle/include/rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp
Show resolved
Hide resolved
Comment on lines
-63
to
-66
| /// Callback function for configure transition | ||
| /* | ||
| * \return SUCCESS by default | ||
| */ |
There was a problem hiding this comment.
was the removal of this intentional?
Author
There was a problem hiding this comment.
it wasn't intentional it was mistake I am sorry for that
Collaborator
There was a problem hiding this comment.
Unresolving this, since it has not been addressed
|
also probably a good idea to squash these commits? though I'm unsure on the policy for stuff like this for this repo/org |
fujitatomoya
requested changes
Mar 3, 2026
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm, all comments need to be resolved.
alsora
reviewed
Mar 3, 2026
rclcpp_lifecycle/include/rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation explaining the difference between FAILURE and ERROR return values for lifecycle callbacks.
Closes #3086