fix: Prevent short time endless loop in expire_timer (backport #1303)#1305
Open
mergify[bot] wants to merge 1 commit intojazzyfrom
Open
fix: Prevent short time endless loop in expire_timer (backport #1303)#1305mergify[bot] wants to merge 1 commit intojazzyfrom
mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
* fix: Prevent short time endless loop in expire_timer There were multiple bugs in this area: - The expire of goals and the re computation of the expire period had a < vs <= issue, leading to goals not expiring, while the period for the next expire was compute as 0 leading to a direct recall of the expire timer. In combination with sim time this lead to 100% CPU spikes. - The period of the expire timer was changed after the reset of the timer, leading to an incorrect next call time of the timer. - The timer was not canceled after the expire event was issued Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * chore: Removed unneeded line Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> --------- Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit 927a33e) # Conflicts: # rcl_action/src/rcl_action/action_server.c
Author
|
Cherry-pick of 927a33e has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
skyegalaxy
requested changes
Mar 23, 2026
| } | ||
| } | ||
|
|
||
| >>>>>>> 927a33e (fix: Prevent short time endless loop in expire_timer (#1303)) |
Member
There was a problem hiding this comment.
this part of the PR is ABI breaking and different from how action goal expiration was handled in Jazzy. We can remove this part and backport the rest of the changes to Jazzy (and Kilted as well, in combination with the action goal expiration backport)
Member
There was a problem hiding this comment.
@skyegalaxy or @jmachowinski: would one of you want to take care of this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were multiple bugs in this area:
This is an automatic backport of pull request #1303 done by [Mergify](https://mergify.com).