Fix for new chromedriver location (extended)#39
Open
ashbythorpe wants to merge 17 commits intoropensci:masterfrom
Open
Fix for new chromedriver location (extended)#39ashbythorpe wants to merge 17 commits intoropensci:masterfrom
ashbythorpe wants to merge 17 commits intoropensci:masterfrom
Conversation
Does renames. Still doesn't move the driver to the right place...
This reverts commit e184b6d.
Author
|
All checks pass! 🎉 |
Author
|
Finished! This PR fixes #34, allowing Chromedriver to be downloaded from the Chrome for Testing site, while still allowing old versions of the driver to be downloaded from the previous site. |
This was referenced May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #35