feat: virtual scrolling for gallery grid view#3170
Open
msedek wants to merge 1 commit intorommapp:masterfrom
Open
feat: virtual scrolling for gallery grid view#3170msedek wants to merge 1 commit intorommapp:masterfrom
msedek wants to merge 1 commit intorommapp:masterfrom
Conversation
zurdi15
requested changes
Mar 26, 2026
Member
zurdi15
left a comment
zurdi15
left a comment
There was a problem hiding this comment.
Can you fix the Typescript check
Also, is it possible for you to sign the commit? It's OK otherwise
msedek
force-pushed
the
pr/gallery-virtual-scroll
branch
from
7aa8072 to
c74aecd
Compare
Replace flat v-for iteration with TanStack Virtual window virtualizer for the gallery cards view. Rows are virtualized so only visible rows are rendered, reducing DOM nodes from hundreds to a few dozen. Changes: - Add @tanstack/vue-virtual dependency - Compute grid columns from Vuetify breakpoints - Virtualize rows with useWindowVirtualizer - Map flat ROM list to virtual grid cells via getRomForCell() - Cast virtualRow.key to String for vue-tsc compatibility Signed-off-by: Miguel Sedek <miguelsedek@gmail.com>
msedek
force-pushed
the
pr/gallery-virtual-scroll
branch
from
d53e9af to
73a9922
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements row-based virtual scrolling for the gallery card grid using
@tanstack/vue-virtual, addressing the performance issue described in #1426 and #3161.Problem
When browsing a platform with 1000+ ROMs, the infinite scroll keeps appending GameCard components to the DOM. After scrolling 500+ cards (~25,000 DOM nodes), clicking a game freezes the browser as Vue destroys all components at once.
Solution
v-foroverfilteredRomswithuseWindowVirtualizerfrom@tanstack/vue-virtualWhat changed
frontend/src/views/Gallery/Platform.vue— template and scriptfrontend/package.json— added@tanstack/vue-virtualdependencyWhat didn't change
Test plan
Tested with 5,600 ROMs across 12 platforms (largest: NES with 1,366 ROMs).
AI-assisted: Claude was used for research and implementation.
Closes #3161