This repository was archived by the owner on Jul 22, 2023. It is now read-only.
Add animation support#37
Open
nezuo wants to merge 3 commits intorojo-rbx:masterfrom
nezuo:animation-support
Open
Add animation support#37nezuo wants to merge 3 commits intorojo-rbx:masterfrom nezuo:animation-support
nezuo wants to merge 3 commits intorojo-rbx:masterfrom
nezuo:animation-support
Conversation
Contributor
Author
|
If this gets the go ahead, I can also add this API to the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for uploading to an existing animation asset. The endpoint that is used for models, does not work for animations.
I wasn't sure how the API should be designed, and I am happy to change it. It feels a little awkward right now because you can still use readModelAsset to read an animation asset.
A possible API could be to just use writeExistingModelAsset, read the asset from the site, and use the necessary endpoint depending on if it is an animation or not.
There is also a lot of code duplication here which might need to get cleaned up.