Skip to content

fix: adjust max pid on macos #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockstar merged 1 commit into from
Sep 7, 2025
Merged

fix: adjust max pid on macos #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,9 @@ fn validate_pid(pid: i32) -> bool {

#[cfg(target_os = "macos")]
{
// macOS uses 32-bit PIDs but typically keeps them much lower
pid <= 99999
// macOS defines PID_MAX as 99999, but process IDs are not assigned
// to PID_MAX, so max pid is 99998.
pid < 99999
}

#[cfg(target_os = "windows")]
Expand Down Expand Up @@ -1626,8 +1627,8 @@ mod tests {

#[cfg(target_os = "macos")]
{
assert!(validate_pid(99999)); // Should be valid on macOS
assert!(!validate_pid(100000)); // Should be invalid
assert!(validate_pid(99998)); // Should be valid on macOS
assert!(!validate_pid(99999)); // Should be invalid
}
}

Expand Down
Loading