Skip to content

Remove rewards health check and log if period has passed already#1045

Merged
0xfornax merged 1 commit intomasterfrom
remove-rewards-health-check
Mar 24, 2026
Merged

Remove rewards health check and log if period has passed already#1045
0xfornax merged 1 commit intomasterfrom
remove-rewards-health-check

Conversation

@thomaspanf
Copy link
Copy Markdown
Member

This PR removes the rewards health check and handles a revert message that occurs when a trusted node tries to submit after the period has already passed:

rocketpool_watchtower  | 2026/03/12 07:21:34 [Merkle Tree] Generation complete! Saving files...
rocketpool_watchtower  | 2026/03/12 07:21:37 [Merkle Tree] Error submitting rewards snapshot: Could not estimate the gas required to submit the rewards tree: Error getting transaction gas info: could not estimate gas limit: error estimating gas needed: execution reverted: Invalid RPL rewards
  • removed the rewards submission health check
  • added logging: Rewards period %s has already reached consensus (current index is %s), skipping submission
  • added bool submitted to the submitRewardsSnapshot signature, that way Run() and generateTreeImpl() can log the results correctly

@github-actions
Copy link
Copy Markdown

Coverage Report

@github-actions
Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool/watchtower 0.52% (-0.00%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/watchtower/constants.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/rocketpool/watchtower/submit-rewards-tree-stateless.go 0.00% (ø) 2143 (+55) 0 2143 (+55)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@thomaspanf thomaspanf marked this pull request as ready for review March 23, 2026 23:39
@0xfornax 0xfornax merged commit 4a07fa6 into master Mar 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants