chore: Remove unused consume_all parameter

[nickdnk]

Q	A
Bugfix?	❌
Breaks BC?	Don't think so
New feature?	❌
Issues	n/a
Docs PR

The consume_all parameter was removed a long time ago and serves no purpose in the v4 version of RoadRunner PHP.

See roadrunner-server/jobs#135

Summary by CodeRabbit

• New Features

  • Streamlined class interfaces for AMQPCreateInfo and BeanstalkCreateInfo by removing the consumeAll functionality.

• Bug Fixes

  • Updated tests to reflect the removal of consumeAll assertions in both AMQPCreateInfoTest and BeanstalkCreateInfoTest.

[coderabbitai]

Walkthrough

The changes involve the removal of the consumeAll property and its associated constant CONSUME_ALL_DEFAULT_VALUE from both the AMQPCreateInfo and BeanstalkCreateInfo classes. Consequently, the constructors of these classes have been updated to eliminate the consumeAll parameter, and the toArray methods have been modified to exclude any references to consumeAll. Corresponding test cases in AMQPCreateInfoTest and BeanstalkCreateInfoTest have also been updated to remove assertions related to the consumeAll property.

Changes

File	Change Summary
src/Queue/AMQPCreateInfo.php	Removed constant CONSUME_ALL_DEFAULT_VALUE, parameter consumeAll from constructor, and updated toArray method to exclude consumeAll.
src/Queue/BeanstalkCreateInfo.php	Removed constant CONSUME_ALL_DEFAULT_VALUE, parameter consumeAll from constructor, and updated toArray method to exclude consumeAll.
tests/Unit/Queue/AMQPCreateInfoTest.php	Removed assertions related to consumeAll in testDefaultValues, testCustomValues, and testToArray.
tests/Unit/Queue/BeanstalkCreateInfoTest.php	Removed assertions and parameters related to consumeAll in testConstructor, testBeanstalkCreateInfoCustomValues, and testToArray.

Poem

In the meadow where bunnies play,
Changes came in a swift ballet.
consumeAll hopped away with glee,
Leaving space for new things to be.
With simpler paths, we now can see,
A brighter future, just wait and see! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1df9702 and 162e3a6.

📒 Files selected for processing (4)

• src/Queue/AMQPCreateInfo.php (0 hunks)
• src/Queue/BeanstalkCreateInfo.php (0 hunks)
• tests/Unit/Queue/AMQPCreateInfoTest.php (0 hunks)
• tests/Unit/Queue/BeanstalkCreateInfoTest.php (2 hunks)

💤 Files with no reviewable changes (3)

• src/Queue/AMQPCreateInfo.php
• src/Queue/BeanstalkCreateInfo.php
• tests/Unit/Queue/AMQPCreateInfoTest.php

🔇 Additional comments (2)

tests/Unit/Queue/BeanstalkCreateInfoTest.php (2)

39-39: LGTM! Constructor parameter removal is consistent.

The removal of the consumeAll parameter from the constructor call aligns with the PR objective to remove this unused parameter.

---

63-63: LGTM! Test array structure correctly updated.

The constructor call and expected array structure have been properly updated to reflect the removal of the consumeAll parameter, maintaining consistency with the implementation changes.

Also applies to: 66-73

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[roxblnfk]

We can't just remove public consts and properties because of BC.

Need to mark them @deprecated and remove usages