This repository was archived by the owner on Jul 15, 2022. It is now read-only.
Wait for DOMContentLoaded event before calling self.init#154
Open
LeShrimp wants to merge 1 commit intornmp:masterfrom
Open
Wait for DOMContentLoaded event before calling self.init#154LeShrimp wants to merge 1 commit intornmp:masterfrom
LeShrimp wants to merge 1 commit intornmp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I had trouble running salvattore. Googling for "salvattore not working" I found http://stackoverflow.com/questions/27120109/salvattore-does-not-work
This problem can easily be avoided by running self.init() only after the DOM has loaded. The proposed solution works for IE9+.
At least for me this change was useful, so I thought you might want to consider this. ;)
Cheers,
Maxime