A batch of small efficiency edits suggested by codex.#192
Merged
Conversation
… instantiated as an actual list
…hts when unneeded.
…ject just to add it to the vector
…ach time from scratch.
… centers for dups, not the whole vector
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More work with codex. This time I had it go through the code looking for ways to make the code more efficient. Just doing static code checking, not profiling.
Most of these are not in particularly tall pole locations in the code, but they all seem worthwhile micro-improvements. The test suite (admittedly not a great test of code speed) changed from taking 429 seconds to 420 seconds on this branch. So not a huge difference, and most users probably won't notice. But there are probably a few use cases where the difference is relatively significant.