fix: add package-lock.json for predictable dependency tree and update bunchee#414
Merged
fix: add package-lock.json for predictable dependency tree and update bunchee#414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest build failed due to some Rollup errors that didn't happen locally. This should be attributed to the lack of a committed
package-lock.jsonfile so CI installs potentially different (and breaking) dependencies compared to local which caused the error there.Looks like bumping our build manager
buncheeto the next major version (which switches from rollup + typescript plugin toswc) alleviates this.We should probably commit this package-lock.json to this repo now - it doesn't get included in the npm release builds anyways and creates a more stable dev environment for CI and other folks running this repo locally.
On inspecting the build with this change, there should be no difference in usage for package consumers.