Skip to content

feat: add getPropertyCountAsync and getInstanceCountAsync and deprecate propertyCount and instanceCount#198

Merged
mfazekas merged 1 commit intomainfrom
feat/async-property-instance-count
Mar 30, 2026
Merged

feat: add getPropertyCountAsync and getInstanceCountAsync and deprecate propertyCount and instanceCount#198
mfazekas merged 1 commit intomainfrom
feat/async-property-instance-count

Conversation

@mfazekas
Copy link
Copy Markdown
Collaborator

@mfazekas mfazekas commented Mar 30, 2026

Summary

  • Add getPropertyCountAsync() and getInstanceCountAsync() async methods to ViewModel
  • Deprecate sync propertyCount and instanceCount properties — the experimental Rive runtime requires async calls, and sync versions use blocking wrappers that can deadlock on the main thread
  • Legacy implementations wrap the existing sync getters in Promise.async
  • Update harness test to use async methods

Test plan

  • Run databinding-advanced harness tests on iOS and Android

@mfazekas mfazekas changed the title feat: add getPropertyCountAsync and getInstanceCountAsync feat: add getPropertyCountAsync and getInstanceCountAsync and deprecate propertyCount and instanceCount Mar 30, 2026
@mfazekas mfazekas requested a review from HayesGordon March 30, 2026 13:37
Copy link
Copy Markdown
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfazekas mfazekas merged commit 6244b2e into main Mar 30, 2026
9 checks passed
@mfazekas mfazekas deleted the feat/async-property-instance-count branch March 30, 2026 16:44
mfazekas pushed a commit that referenced this pull request Mar 30, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.3.4](v0.3.3...v0.3.4)
(2026-03-30)


### Features

* add getPropertyCountAsync and getInstanceCountAsync and deprecate
propertyCount and instanceCount
([#198](#198))
([6244b2e](6244b2e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants