Add getDefaultViewModelInfo to experimental API#443
Open
mfazekas wants to merge 4 commits intorive-app:masterfrom
Open
Add getDefaultViewModelInfo to experimental API#443mfazekas wants to merge 4 commits intorive-app:masterfrom
mfazekas wants to merge 4 commits intorive-app:masterfrom
Conversation
Add the ability to query the default view model name and instance name for an artboard through the experimental CommandQueue API. This mirrors the iOS experimental SDK's File.getDefaultViewModelInfo(for:) which already exists. The name is needed for file-level queries like getViewModelProperties() and getViewModelInstanceNames() which are keyed by view model name — without it, ViewModelSource.DefaultForArtboard users cannot access those APIs. Changes: - CommandQueueBridge: add cppGetDefaultViewModelInfo JNI declaration - CommandQueue: add getDefaultViewModelInfo suspend function + callback - RiveFile: add public getDefaultViewModelInfo(artboard) API - DefaultViewModelInfo: new data class for the result - bindings_command_queue.cpp: JNI binding + ArtboardListener callback
mfazekas
force-pushed
the
feat/get-default-viewmodel-info
branch
from
3e94c26 to
c73ef7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
RiveFile.getDefaultViewModelInfo(artboard)to the experimental API, returning aDefaultViewModelInfo(viewModelName, instanceName). This mirrors the iOS experimental SDK'sFile.getDefaultViewModelInfo(for:)which already exists. Without this,ViewModelSource.DefaultForArtboardusers cannot callgetViewModelProperties(name)orgetViewModelInstanceNames(name)since those are keyed by view model nameiOS reference
The C++ runtime already supports
requestDefaultViewModelInfo(incommand_queue.cpp). iOS wires it through:ArtboardService.getDefaultViewModelInfo()→commandQueue.requestDefaultViewModelInfo()File.getDefaultViewModelInfo(for: artboard)→ public APIThis PR adds the equivalent Android wiring.