refactor: deduplicate TranscriptionConfigDialog with shared form helpers#440
Open
alexander-turner wants to merge 2 commits intorishikanthc:mainfrom
Open
Conversation
- Extract SelectField, SwitchField, SliderField, AdvancedAccordion to FormHelpers - Move shared CSS class constants (inputClassName, etc.) to FormHelpers - Extract DiarizationSection to eliminate 3x copy-pasted diarization blocks - Replace 11 inline Select blocks, 5 Switch+label blocks, 2 Slider blocks, 2 Accordion wrappers with single-line helper calls TranscriptionConfigDialog: 1178 → 702 lines (-40%) FormHelpers: 119 → 264 lines (reusable form infrastructure) https://claude.ai/code/session_01YMyUwpk577EradV93tMMqS
Remove 4 duplicated CSS class constants and replace manual Select/Switch blocks with SelectField and SwitchField from FormHelpers. 225 → 185 lines (-18%) https://claude.ai/code/session_01YMyUwpk577EradV93tMMqS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectField,SwitchField,SliderField,AdvancedAccordionhelpers intoFormHelpers.tsx— reusable across any config dialoginputClassName, etc.) toFormHelpers.tsxDiarizationSectioncomponent to eliminate 3x copy-pasted diarization blocks (Whisper, Parakeet, Canary)