Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ❌ | Missing directories: data/processed/event_logs |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ❌ | Missing files in data/processed/event_logs |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
For completing Part 2 of the assignment refer to instructions in https://github.com/UofT-DSI/shell/blob/main/02_activities/assignments/assignment_instructions.md
| # 5. Copy all server log files (files with "server" in the name AND a .log extension) from ./data/raw to ./data/processed/server_logs | ||
| mkdir -p data/processed/server_logs | ||
| mkdir -p data/processed/user_logs | ||
| mkdir -p data/processed/user_logs |
There was a problem hiding this comment.
You have a bug here. Its probably caused by copy and paste. The user_logs dir is created twice. It should be event_logs dir instead.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/processed/user_logs not removed |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | Missing files in data/processed/server_logs |
| Part 1 - Q6 | ❌ | Missing files in data/processed/user_logs; Missing files in data/processed/event_logs |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed. |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ✅ |
Please address the issues listed above.
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Please make the requested review changes.
|
|
||
| # 1. Create a directory named data | ||
|
|
||
| # 2. Move the ./rawdata directory to ./data/raw (eg. move it into ./data and rename it to raw) |
There was a problem hiding this comment.
Please add these comments back that contain the questions. The lines are deleted. It makes it harder to review.
| # 2. Move the ./rawdata directory to ./data/raw (eg. move it into ./data and rename it to raw) | ||
| mkdir data | ||
|
|
||
| # 3. List the contents of the ./data/raw directory |
There was a problem hiding this comment.
Add comment back in the code. The comments # 1. # 2. etc shouldn't be deleted. Also, the command that answers the question should be underneath that question. E.g:
# 1. Create a directory named data
mkdir data
| mkdir -p data/processed/user_logs | ||
| mkdir -p data/processed/event_logs | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
These are conflict marker (<<<< ===== >>>>> ) that you must have got when you merged coworker-changes branch when you did Part 2 of assignment.
They should be deleted when you resolved conflict.
Please delete <<<<<<< HEAD line of code.
| cp data/raw/*server*.log data/processed/server_logs/ | ||
| cp data/raw/*user*.log data/processed/user_logs/ | ||
| cp data/raw/*event*.log data/processed/event_logs/ | ||
| ======= |
There was a problem hiding this comment.
conflict marker (<<<< ===== >>>>> ) that must be deleted
| # 6. Repeat the above step for user logs and event logs | ||
|
|
||
| # 7. For user privacy, remove all files containing IP addresses (files with "ipaddr" in the filename) from ./data/raw and ./data/processed/user_logs | ||
| rf -rf ./data |
There was a problem hiding this comment.
The rf -rf ./data code should be deleted when resolving conflicts on merging coworker-changes branch changes with assignment branch. Its incorrect code which is attempting to delete data directory.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | Missing files in data/processed/server_logs |
| Part 1 - Q6 | ❌ | Missing files in data/processed/user_logs; Missing files in data/processed/event_logs |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed. |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ✅ |
Please address the issues listed above.
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
The changes look good. Well done.
3 participants
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist