Conversation
The raw dump target (using dd to a partition) is being phased out in favor of filesystem-based targets. This patch adds deprecation warnings to the documentation and runtime scripts to alert users that support will be removed in a future release. Resolves: rhkdump#141 Assisted-by: Google Gemini Signed-off-by: Lichen Liu <lichliu@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates the deprecation process for raw dump targets within the kdump system. It introduces clear warnings in both user-facing documentation and the core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively deprecates the raw dump target by adding warnings to documentation and runtime scripts. The changes are clear and well-implemented. I have one suggestion to improve the runtime deprecation message to make it more actionable for users.
| fi | ||
| ;; | ||
| raw) | ||
| dwarn "Raw targets will be deprecated and removed in the future. Please migrate to a supported dump target." |
There was a problem hiding this comment.
The deprecation warning is a great addition. To make it more actionable for users, consider mentioning some examples of supported filesystem-based targets. This helps guide them toward a valid configuration without them necessarily needing to consult the documentation for examples.
| dwarn "Raw targets will be deprecated and removed in the future. Please migrate to a supported dump target." | |
| dwarn "The 'raw' dump target is deprecated and will be removed in a future release. Please migrate to a filesystem-based dump target (e.g., ext4, xfs, nfs, or ssh)." |
The raw dump target (using dd to a partition) is being phased out in favor of filesystem-based targets. This patch adds deprecation warnings to the documentation and runtime scripts to alert users that support will be removed in a future release.
Due to editor settings, this patch also removes some trailing spaces.
Resolves: #141
Assisted-by: Google Gemini