Skip to content

kdumpctl: Deprecate raw dump targets#149

Open
licliu wants to merge 1 commit intorhkdump:mainfrom
licliu:raw_target_deprecate
Open

kdumpctl: Deprecate raw dump targets#149
licliu wants to merge 1 commit intorhkdump:mainfrom
licliu:raw_target_deprecate

Conversation

@licliu
Copy link
Collaborator

@licliu licliu commented Mar 20, 2026

The raw dump target (using dd to a partition) is being phased out in favor of filesystem-based targets. This patch adds deprecation warnings to the documentation and runtime scripts to alert users that support will be removed in a future release.

Due to editor settings, this patch also removes some trailing spaces.

Resolves: #141

Assisted-by: Google Gemini

The raw dump target (using dd to a partition) is being phased out in
favor of filesystem-based targets. This patch adds deprecation warnings
to the documentation and runtime scripts to alert users that support
will be removed in a future release.

Resolves: rhkdump#141

Assisted-by: Google Gemini
Signed-off-by: Lichen Liu <lichliu@redhat.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates the deprecation process for raw dump targets within the kdump system. It introduces clear warnings in both user-facing documentation and the core kdumpctl script, guiding users towards more robust filesystem-based alternatives. The changes aim to streamline future development by phasing out an older, less flexible method of crash dump collection.

Highlights

  • Deprecation of Raw Dump Targets: Added deprecation warnings across documentation and runtime scripts for 'raw' dump targets, signaling their eventual removal in favor of filesystem-based targets.
  • Documentation Updates: Updated the kdump.conf man page, gen-kdump-conf.sh comments, and kexec-kdump-howto.txt to reflect the deprecation policy.
  • Runtime Warning: Implemented a runtime warning in the kdumpctl script to alert users when a 'raw' dump target is configured.
  • Code Clean-up: Removed various trailing spaces from several files, improving code consistency and readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively deprecates the raw dump target by adding warnings to documentation and runtime scripts. The changes are clear and well-implemented. I have one suggestion to improve the runtime deprecation message to make it more actionable for users.

fi
;;
raw)
dwarn "Raw targets will be deprecated and removed in the future. Please migrate to a supported dump target."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The deprecation warning is a great addition. To make it more actionable for users, consider mentioning some examples of supported filesystem-based targets. This helps guide them toward a valid configuration without them necessarily needing to consult the documentation for examples.

Suggested change
dwarn "Raw targets will be deprecated and removed in the future. Please migrate to a supported dump target."
dwarn "The 'raw' dump target is deprecated and will be removed in a future release. Please migrate to a filesystem-based dump target (e.g., ext4, xfs, nfs, or ssh)."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the support for raw targets

1 participant