Fix checking sscanf return value as the value can be 0 causing undefined behavior in snprintf#146
Open
PwnVerse wants to merge 1 commit intorhboot:fedora-39from
Open
Fix checking sscanf return value as the value can be 0 causing undefined behavior in snprintf#146PwnVerse wants to merge 1 commit intorhboot:fedora-39from
PwnVerse wants to merge 1 commit intorhboot:fedora-39from
Conversation
PwnVerse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since device is taken as an argument (
argv[1]), in ofcpath.c, a seemingly malicious device for instance the string/pci@1f,0/pci@1/scsi@8/sd@0,0can cause sscanf to return 0 and in turn causepartto become negative in snprintf and cause undefined behaviour.